[Webkit-unassigned] [Bug 191062] Align entries in metadata table

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191062

Yusuke Suzuki <yusukesuzuki at slowstart.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yusukesuzuki at slowstart.org
 Attachment #353371|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 353371
  --> https://bugs.webkit.org/attachment.cgi?id=353371
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353371&action=review

> Source/JavaScriptCore/bytecode/Opcode.cpp:202
> +static unsigned metadataAlignments[] = {
> +
> +#define METADATA_ALIGNMENT(size) size,
> +    FOR_EACH_BYTECODE_METADATA_ALIGNMENT(METADATA_ALIGNMENT)
> +#undef METADATA_ALIGNMENT
> +
> +};

This data is not necessary if `CPU(NEEDS_ALIGNED_ACCESS)` is false. Let's guard with this condition and drop this data from the binary.

> Source/JavaScriptCore/bytecode/Opcode.cpp:212
> +unsigned metadataAlignment(OpcodeID opcodeID)
> +{
> +    return metadataAlignments[opcodeID];
> +}

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181030/3e53c4b6/attachment.html>