[Webkit-unassigned] [Bug 191067] [GTK] Scrollbars not following gtk-primary-button-warps-slider setting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 11:13:31 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=191067

--- Comment #9 from Jim Mason <jmason at ibinx.com> ---
(In reply to Michael Catanzaro from comment #7)
> Comment on attachment 353369 [details]
> Patch
> 
> Oooh, cool! Nice, especially if this is your first contribution.
> 
> I have two suggestions:
> 
>  (1) WebKit style is that the comment should be a complete sentence that
> starts with a capital and ends with a period.
> 
>  (2) The ^ is too clever for my taste; can you write it out with
> conditionals so that it's easier to read?
> 
> Thanks!

Good feedback, thanks!  The changes have been applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181030/ea60f06d/attachment-0001.html>


More information about the webkit-unassigned mailing list