[Webkit-unassigned] [Bug 183060] [Curl][WinCairo] Add Public Suffix support to WinCairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 09:00:45 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=183060

--- Comment #24 from Claudio Saavedra <csaavedra at igalia.com> ---
(In reply to Christopher Reid from comment #21)
> It looks like some of these imported mac test cases are failing on GTK
> 
> Here's the result of my run:
> 
> > **FAIL** PublicSuffix.IsPublicSuffix
> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:81
> > Value of: isPublicSuffix("COM")
> >   Actual: false
> > Expected: true

This is failing because we don't downcase the string before passing it to libsoup. Libsoup expects it to be downcased (it's not documented anywhere for some reason but so it is).

> > 
> > **FAIL** PublicSuffix.TopPrivatelyControlledDomain
> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:156
> > Expected equality of these values:
> >   utf16String(u"\u6803\u6728.jp")
> >     Which is: xn--4pvxs.jp
> >   topPrivatelyControlledDomain(utf16String(u"\u6803\u6728.jp"))
> >     Which is: 

栃木.jp is in the public-domain suffix list, from what I understand this is not a registrable domain (it's a public one). So I think this test is wrong and should be removed.

> > 
> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:177
> > Expected equality of these values:
> >   String("example.com")
> >     Which is: example.com
> >   topPrivatelyControlledDomain("ExamPle.com")
> >     Which is: ExamPle.com
> > 

Same as first one.

> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:178
> > Expected equality of these values:
> >   String("example.com")
> >     Which is: example.com
> >   topPrivatelyControlledDomain("SUB.dOmain.ExamPle.com")
> >     Which is: ExamPle.com
> > 
> > 

Ditto.

> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:179
> > Expected equality of these values:
> >   String("localhost")
> >     Which is: localhost
> >   topPrivatelyControlledDomain("localhost")
> >     Which is: 
> > 
> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:180
> > Expected equality of these values:
> >   String("localhost")
> >     Which is: localhost
> >   topPrivatelyControlledDomain("LocalHost")
> >     Which is: 
> > 
> > 

These two are special-cased in the Mac implementation. We should do the same.


> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:181
> > Expected equality of these values:
> >   String("åäö")
> >     Which is: åäö
> >   topPrivatelyControlledDomain("åäö")
> >     Which is: 
> > 
> > 
> > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:182
> > Expected equality of these values:
> >   String("ÅÄÖ")
> >     Which is: Ã
> > Ã
> >  Ã
> >   topPrivatelyControlledDomain("ÅÄÖ")
> >     Which is:

The error checking in the soup implementation is wrong so that's why these fail. Fixing those raises a few more failures. I'll file a new bug for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181029/08fb02d6/attachment.html>


More information about the webkit-unassigned mailing list