[Webkit-unassigned] [Bug 190912] http/wpt/cache-storage/cache-quota.any.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190912

--- Comment #5 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to Michael Catanzaro from comment #4)
> >> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:117
> >> +    WKWebsiteDataStoreSetQuota(websiteDataStore, 400 * 1024);
> > 
> > I think you should do the same for WPE.
> 
> This should be done in the main TestController.cpp, not here. Then remove
> the Mac-specific API call from TestControllerCocoa.mm. And then remove the
> Mac-specific API entirely (from WKWebsiteDataStorePrivate.h and
> WKWebsiteDataStore.mm), since it's only used in one place by TestController
> and there's nothing platform-specific about it.

I agree with Michael and we had already discussed with Darshan about moving to the main TestController class. Since he is new to WebKit, I think it's ok to start with just the minimal changes to make tests pass on WPE/GTK and then do follow-up refactoring so that the quota limit is set on all platforms at one place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181026/7dff7354/attachment.html>