[Webkit-unassigned] [Bug 190912] http/wpt/cache-storage/cache-quota.any.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 12:13:37 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190912

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fred.wang at free.fr
 Attachment #353098|review?                     |review-
              Flags|                            |

--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 353098
  --> https://bugs.webkit.org/attachment.cgi?id=353098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353098&action=review

You need to remove the failures from LayoutTests/platform/gtk/TestExpectations and LayoutTests/platform/wpe/TestExpectations. Let's do that on bug 178316 directly.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:116
> +WK_EXPORT void WKWebsiteDataStoreSetQuota(WKWebsiteDataStoreRef dataStoreRef, uint64_t quota);

I'm not familiar with the rules to introduce new API, so let's see what other reviewers say.

> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:117
> +    WKWebsiteDataStoreSetQuota(websiteDataStore, 400 * 1024);

I think you should do the same for WPE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181025/ac1079f7/attachment.html>


More information about the webkit-unassigned mailing list