[Webkit-unassigned] [Bug 190863] Customizable test group form should not reset manually edited commit value sometimes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190863

--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 353022
  --> https://bugs.webkit.org/attachment.cgi?id=353022
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353022&action=review

> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:255
> +                if (ownerRepository)

The correct logic should be avoid updating commit for repositories with owner.

> Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:270
> +                    const originalCommit = originalCommitSetMap[labelToChoose].commitForRepository(repository) || commit;

If this repository exists in originalCommitSetMap, we the radio button should set the value from original commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181024/95ae9684/attachment.html>