[Webkit-unassigned] [Bug 190838] New: Cleanup: MIMETypeRegistry functions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 23 12:24:05 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=190838
Bug ID: 190838
Summary: Cleanup: MIMETypeRegistry functions
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Images
Assignee: webkit-unassigned at lists.webkit.org
Reporter: sabouhallawa at apple.com
Some of the functions in MIMETypeRegistry return HashSet<Sting>. For these functions, we need to do the following:
1. Use NeverDestroyed<> instead of allocating raw pointers with the new operator.
2. Use std::initializer_list to initialize the static HashSet<String> when the list of supported mime types is static list of strings.
3. Use makeNeverDestroyed() to initialize the static HashSet<String> when the list of supported mime types is retrieved from a system call.
3. Replace the functions MIMETypeRegistry::getSupported...() with MIMETypeRegistry::supported...(). The functions whose names are MIMETypeRegistry::supported...() will be responsible of filling and validating their local NeverDestroyed<> and returning the underlaying HashSets.
4. As a preparation for landing 190454, the term UTI will be replaced by ImageSourceType. A new SPI will be added and adding UTI in its name does not seem appealing.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181023/f4140990/attachment.html>
More information about the webkit-unassigned
mailing list