[Webkit-unassigned] [Bug 190696] [LFC][IFC] Add generic inline run generator.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190696

--- Comment #4 from zalan <zalan at apple.com> ---
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 352679 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352679&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineRunProvider.h:100
> > +        Run(const InlineItem&, Type);
> > +        Run(const InlineItem&, Type, TextContext);
> 
> Could just take std::optional<TextContext> and combine these.
> 
> > Source/WebCore/layout/inlineformatting/InlineRunProvider.h:108
> > +    using Runs = Vector<InlineRunProvider::Run>;
> > +
> > +    const Runs& runs() const { return m_inlineRuns; }
> 
> Just using Vector<InlineRunProvider::Run> might be clearer an alias.
> 
> > Source/WebCore/layout/layouttree/LayoutInlineBox.cpp:39
> > +InlineBox::InlineBox(std::optional<ElementAttributes> attributes, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
> 
> BaseTypeFlags stuff should really be using OptionSet these days.
Yea, indeed. I'll fix it in a separate patch.

Thanks for the review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181019/fc09826f/attachment.html>