[Webkit-unassigned] [Bug 190696] [LFC][IFC] Add generic inline run generator.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 19 07:35:12 PDT 2018


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
 Attachment #352679|review?                     |review+
              Flags|                            |

--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 352679
  --> https://bugs.webkit.org/attachment.cgi?id=352679

View in context: https://bugs.webkit.org/attachment.cgi?id=352679&action=review

> Source/WebCore/layout/inlineformatting/InlineRunProvider.h:100
> +        Run(const InlineItem&, Type);
> +        Run(const InlineItem&, Type, TextContext);

Could just take std::optional<TextContext> and combine these.

> Source/WebCore/layout/inlineformatting/InlineRunProvider.h:108
> +    using Runs = Vector<InlineRunProvider::Run>;
> +
> +    const Runs& runs() const { return m_inlineRuns; }

Just using Vector<InlineRunProvider::Run> might be clearer an alias.

> Source/WebCore/layout/layouttree/LayoutInlineBox.cpp:39
> +InlineBox::InlineBox(std::optional<ElementAttributes> attributes, RenderStyle&& style, BaseTypeFlags baseTypeFlags)

BaseTypeFlags stuff should really be using OptionSet these days.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181019/c00f018b/attachment.html>

More information about the webkit-unassigned mailing list