[Webkit-unassigned] [Bug 190744] New: [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 18 21:20:55 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=190744
Bug ID: 190744
Summary: [Win][Clang] WebView.h: warning: 'QueryInterface'
overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebKit Misc.
Assignee: webkit-unassigned at lists.webkit.org
Reporter: Hironori.Fujii at sony.com
Blocks: 171618
[Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
clang-cl reports following compilation warnings.
> [5812/6203] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebView.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:28:
> ..\..\Source\WebKitLegacy\win/WebView.h(115,39): warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
> ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(113,47): note: overridden virtual function is here
> virtual HRESULT STDMETHODCALLTYPE QueryInterface(
> ^
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:28:
> ..\..\Source\WebKitLegacy\win/WebView.h(116,37): warning: 'AddRef' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual ULONG STDMETHODCALLTYPE AddRef();
> ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(117,45): note: overridden virtual function is here
> virtual ULONG STDMETHODCALLTYPE AddRef( void) = 0;
> ^
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:28:
> ..\..\Source\WebKitLegacy\win/WebView.h(117,37): warning: 'Release' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual ULONG STDMETHODCALLTYPE Release();
> ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(119,45): note: overridden virtual function is here
> virtual ULONG STDMETHODCALLTYPE Release( void) = 0;
> ^
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:28:
> ..\..\Source\WebKitLegacy\win/WebView.h(120,39): warning: 'canShowMIMEType' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual HRESULT STDMETHODCALLTYPE canShowMIMEType(_In_ BSTR mimeType, _Out_ BOOL*);
> ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(42833,43): note: overridden virtual function is here
> virtual HRESULT STDMETHODCALLTYPE canShowMIMEType(
> ^
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:28:
> ..\..\Source\WebKitLegacy\win/WebView.h(121,39): warning: 'canShowMIMETypeAsHTML' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual HRESULT STDMETHODCALLTYPE canShowMIMETypeAsHTML(_In_ BSTR mimeType, _Out_ BOOL*);
> ^
Referenced Bugs:
https://bugs.webkit.org/show_bug.cgi?id=171618
[Bug 171618] [Win][Meta] Build WebKit using Clang
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181019/93e26e5c/attachment.html>
More information about the webkit-unassigned
mailing list