[Webkit-unassigned] [Bug 188174] [WinCairo] Search terms are not saved for <input type="search">

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 18:16:54 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188174

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352735|                            |review-
              Flags|                            |

--- Comment #28 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 352735
  --> https://bugs.webkit.org/attachment.cgi?id=352735
Save windows search inputs to sqlite db

View in context: https://bugs.webkit.org/attachment.cgi?id=352735&action=review

Look good to me. Please add ChangeLog entry. I need to review it, too, to mark r+.

> Source/WebCore/platform/win/SearchPopupMenuDB.cpp:89
> +    for (const auto &search : searches) {

Nit: auto&
https://webkit.org/code-style-guidelines/#pointers-cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181019/33b03861/attachment.html>


More information about the webkit-unassigned mailing list