[Webkit-unassigned] [Bug 188174] [WinCairo] Search terms are not saved for <input type="search">

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188174

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352647|review?                     |review-
              Flags|                            |

--- Comment #23 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 352647
  --> https://bugs.webkit.org/attachment.cgi?id=352647
Save windows search inputs to sqlite db

View in context: https://bugs.webkit.org/attachment.cgi?id=352647&action=review

> Source/WebCore/PlatformWin.cmake:105
> +    platform/win/SearchPopupMenuWinDB.cpp

This is almost platform independent. Remove 'Win'. It is OK for me to put this file in this platform/win/ dir until other ports reuse this.

> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:25
> +#include <WebCore/FileSystem.h>

Do you use <WebCore/FileSystem.h> in this file?

> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:27
> +#include <wtf/text/win/WCharStringExtras.h>

Do you use <wtf/text/win/WCharStringExtras.h> in this file?

> Source/WebCore/platform/win/SearchPopupMenuWinDB.cpp:35
> +static const String createSearchTableSQL {

String ctor calls fastMalloc. Do not define String global variables.
Use WTF::ASCIILiteral instead.
> static constexpr auto createSearchTableSQL = "..."_s;

> Source/WebCore/platform/win/SearchPopupMenuWinDB.cpp:38
> +    "    ind INTEGER NOT NULL,"

ind -> index
https://webkit.org/code-style-guidelines/#names-full-words

> Source/WebCore/platform/win/SearchPopupMenuWinDB.cpp:58
> +    static SearchPopupMenuDB inst;

inst -> instance
https://webkit.org/code-style-guidelines/#names-full-words

> Source/WebCore/platform/win/SearchPopupMenuWinDB.cpp:81
> +    SQLiteTransaction xact(m_database, false);

xact -> transaction
https://webkit.org/code-style-guidelines/#names-full-words

> Source/WebCore/platform/win/SearchPopupMenuWinDB.cpp:82
> +    auto rem = getPreparedStatement(removeSearchTermsForNameSQL);

https://webkit.org/code-style-guidelines/#names-full-words

> Source/WebCore/platform/win/SearchPopupMenuWinDB.h:43
> +    static WEBCORE_EXPORT SearchPopupMenuDB &instance();

instance -> singleton
https://webkit.org/code-style-guidelines/#singleton-static-member

> Source/WebCore/platform/win/SearchPopupMenuWinDB.h:63
> +    HashMap<String, std::unique_ptr<SQLiteStatement>> m_statements;

Do you really need this HashMap? 
https://trac.webkit.org/wiki/InvestigatingLeaksAndBloat

> m_loadSearchTermsForNameStatement = createPreparedStatement(loadSearchTermsForNameSQL);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181018/1141afe1/attachment.html>