[Webkit-unassigned] [Bug 190537] [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190537

--- Comment #6 from Guillaume Emont (jsc-armv7-ews) <guijemont+jsc-armv7-ews at igalia.com> ---
(In reply to Guillaume Emont (jsc-armv7-ews) from comment #5)
> (In reply to Alexey Proskuryakov from comment #4)
> > Comment on attachment 352204 [details]
> > Patch
> > 
> > The patch looks good.
> > 
> > I’m not so sure about the idea of passing options via environment. The port
> > object is supposed to implement the knowledge of how to run tools, and
> > passing arguments verbatim violates incapsulation. 
> > 
> > Why was this approach chosen?
> 
> The goal is to be able to pass a --remote-config-file option so that
> run-javascriptcore-tests runs the test on the correct devices, which are
> dependent on the machine where it is run and not on the port.

Also, I'd love if that could be a parameter to webkit-patch <name of ews queue>, but I could not find a simple way to do that, and saw that there was a precedent with MAKEFLAGS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/d3375670/attachment.html>