[Webkit-unassigned] [Bug 190537] [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190537

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352204|review?                     |review+
              Flags|                            |

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 352204
  --> https://bugs.webkit.org/attachment.cgi?id=352204
Patch

The patch looks good.

I’m not so sure about the idea of passing options via environment. The port object is supposed to implement the knowledge of how to run tools, and passing arguments verbatim violates incapsulation. 

Why was this approach chosen?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/77752c35/attachment-0001.html>