[Webkit-unassigned] [Bug 190517] [PSON] Prewarm system fallback fonts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190517

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352165|review?                     |review+
              Flags|                            |

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 352165
  --> https://bugs.webkit.org/attachment.cgi?id=352165
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352165&action=review

> Source/WebCore/page/ProcessWarming.cpp:93
> +    prewarmInformation.fontCache = FontCache::singleton().collectPrewarmInformation();
> +    return prewarmInformation;

Can't we just do this?:
return { FontCache::singleton().collectPrewarmInformation() };

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1538
> +    if (prewarmInformation.seenFamilies.isEmpty() && prewarmInformation.fontNamesRequiringSystemFallback.isEmpty())

Maybe we can add PrewarmInformation::isEmpty?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/315c9130/attachment.html>