[Webkit-unassigned] [Bug 190440] WebKit Inspector: Expose Server Timing Response Headers in Network Tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190440

--- Comment #10 from cvazac at gmail.com ---
Comment on attachment 351984
  --> https://bugs.webkit.org/attachment.cgi?id=351984
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351984&action=review

>> Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.js:108
>> +        if (typeof duration !== "undefined") {
> 
> Nit: Since we don't need to worry about backwards compatibility this can be:
> 
>     if (duration !== undefined) {
>         ...
>     }
> 
> I'm assuming this is to allow zero as a valid value. If not, then you could just do:
> 
>     if (duration) {
>         ...
>     }

That's right, we need to support zeroes, I added a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/2b555d89/attachment.html>