[Webkit-unassigned] [Bug 190467] Use finer grained locking in FontDatabase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190467

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com
 Attachment #352038|review?                     |review+
              Flags|                            |

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 352038
  --> https://bugs.webkit.org/attachment.cgi?id=352038
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352038&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-893
> -        std::lock_guard<Lock> locker(m_descriptorMapLock);
> -
>          auto folded = familyName.foldCase();
> -        return m_familyNameToFontDescriptors.ensure(folded, [&] {

Wouldn't moving the lock_guard to after the call to foldCase have the same result?  we could leave the call to ensure as it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181011/16395ee2/attachment.html>