[Webkit-unassigned] [Bug 190419] Performance dashboard should show added iterations due failed build requests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 20:08:30 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190419

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351929|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 351929
  --> https://bugs.webkit.org/attachment.cgi?id=351929
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review

> Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374
> +            this.content('status-summary').innerHTML = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`;

Let's store values in local variables first so that the template literal looks nicer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181010/eefbb723/attachment.html>


More information about the webkit-unassigned mailing list