[Webkit-unassigned] [Bug 189239] [EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189239

--- Comment #10 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #7)
> Comment on attachment 351599 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351599&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1292
> > +        (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ? weakThis->m_player->initializationDataEncountered("webm"_s, ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()), initData.sizeInBytes())) : weakThis->m_player->initializationDataEncountered("cenc"_s, ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()), initData.sizeInBytes()));
> 
> It would be much simpler to write:
> 
> weakThis->m_player->initializationDataEncountered(eventKeySystemUUID ==
> GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ? "webm"_s : "cenc"_s,
> ArrayBuffer::create(reinterpret_cast<const
> uint8_t*>(initData.characters8()), initData.sizeInBytes()));
> 

Absolutely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181008/eed08963/attachment.html>