[Webkit-unassigned] [Bug 190327] [Xcode] Never build yasm with ASAN

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190327

--- Comment #3 from mitz at webkit.org ---
Comment on attachment 351719
  --> https://bugs.webkit.org/attachment.cgi?id=351719
Opt yasm out of ASAN

View in context: https://bugs.webkit.org/attachment.cgi?id=351719&action=review

>> Tools/asan/asan.xcconfig:16
>> +CLANG_ADDRESS_SANITIZER_NO = YES;
> 
> Is it working?
> Should we set WK_ASAN_ALLOWED = NO in yasm.xcconfig and 
> CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_ALLOWED));
> CLANG_ADDRESS_SANITIZER_NO = NO;

By convention, if a build setting is not specified, it’s equivalent to being set to NO. So if we wanted a build setting that means “ASAN allowed” we’d have to remember to explicitly set it to YES in every project. Since this is such a rare exception, I opted for something we set in the one place where we make the exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181006/d36940b5/attachment.html>