[Webkit-unassigned] [Bug 190190] Allow run-javascriptcore-tests to distribute tests between devices

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190190

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #8 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 351595
  --> https://bugs.webkit.org/attachment.cgi?id=351595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351595&action=review

Informally reviewing… patch LGTM, with a comment/suggestion
for a follow-up patch.

> Tools/Scripts/run-jsc-stress-tests:321
> +$progressMeter = ($verbosity == 0 and $stdout.tty? and $remoteHosts.length <= 1)

It would be nicer to have some kind of progress meter also in multiple
remote host mode, but I understand it may complicate the script further,
due to having to track the progress for each remote host separately and
then aggregate them for display. Do you have any thoughts about this?

I wouldn't block landing the patch on this (the functionality *is* a
good thing for parallelizing and running tests faster, and faster testing
is always better!), but I think a follow-up patch that adds support for
progress report with multiple remotes would be valuable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/dfdaba70/attachment.html>