[Webkit-unassigned] [Bug 190300] [WPE][JSC] Use Unified Sources for Platform-specific sources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190300

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 351647
  --> https://bugs.webkit.org/attachment.cgi?id=351647
Patch

Patch LGTM. We'll need a reviewer to set the r+, tho.

Something that I am not particularly happy about is in general the unified
sources mechanism (so this is nothing about your patch in particular, so
no worries) because the way it works it basically breaks a lot of tooling:
using YCM, code indexers, clangd/ccls, and many more “sees” the unified
sources when what the tooling really needs to see is the original sources.
But the build speed improvement is too good to let it go... ¬_¬

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/5c446657/attachment.html>