[Webkit-unassigned] [Bug 190302] Expose whether WKWebProcessPlugInNodeHandle is a select element to clients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190302

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351653|commit-queue?               |commit-queue+
              Flags|                            |

--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 351653
  --> https://bugs.webkit.org/attachment.cgi?id=351653
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=351653&action=review

>>> Tools/TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm:45
>>> +    WKDOMElement *htmlElement = [document createElement:htmlElementTag];
>> 
>> I don’t know this API well enough; what’s the ownership story for this object returned from a -create method?
> 
> `htmlElement` holds a reference to the object and once the method returns, nothing holds a reference to the object and the object gets deallocated.

No, that's not right, because this project doesn't build with ARC.

However, I think the code is fine, because createElement returns an autoreleased object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/666b1496/attachment.html>