[Webkit-unassigned] [Bug 189239] [EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189239

--- Comment #5 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #4)
> Comment on attachment 351539 [details]
> Patch
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1295
> > +        if (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID)
> > +            weakThis->m_player->initializationDataEncountered("webm"_s, ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()), initData.sizeInBytes()));
> > +        else
> > +            weakThis->m_player->initializationDataEncountered("cenc"_s, ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()), initData.sizeInBytes()));
> 
> You can use a ? b : c instead of an if.
> 
> I have also a concern of what we are considering here: if system id is
> unspecified then we consider webm, cenc otherwise, which means that cenc
> needs to enforce a sys id and WebM will never have one. I guess the later is
> true by per spec but I wonder if that assumtion of cenc is true.
> 

CENC specifies the system ID and it is mandatory in PSSH Box.


Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:61
> > +    "application/x-cenc, original-media-type=(string)audio/mpeg, protection-system=(string)" WEBCORE_GSTREAMER_EME_UTILITIES_CLEARKEY_UUID";"
> > +    "application/x-webm-enc, original-media-type=(string)video/x-vp8;"
> > +    "application/x-webm-enc, original-media-type=(string)video/x-vp9;"));
> 
> Can WebM handle cenc? If it can then we have an issue with this.
>

Why do you say that? It is "x-webm-enc" not "x-webm-cenc".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181004/f82633e9/attachment.html>