[Webkit-unassigned] [Bug 190250] [Xcode] Update some build settings as recommended by Xcode 10

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 23:17:23 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190250

--- Comment #11 from Build Bot <ews at webkit.org> ---
Attachment 351589 did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.mm:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7358:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7380:  The parameter name "preferences" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7439:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7462:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7464:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7475:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm:115:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1374:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 9 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181004/fb851516/attachment.html>


More information about the webkit-unassigned mailing list