[Webkit-unassigned] [Bug 190258] Gtk build fails with python 3 if LANG and LC_TYPE are unset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190258

Konstantin Tokarev <annulen at yandex.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351542|review-                     |review+
              Flags|                            |

--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 351542
  --> https://bugs.webkit.org/attachment.cgi?id=351542
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351542&action=review

>>> Source/JavaScriptCore/Scripts/cssmin.py:51
>>> +        sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding='UTF-8')
>> 
>> These lines duplicate code above
> 
> I think you're referring to this line:
>          sys.stdin = io.TextIOWrapper(sys.stdin.buffer, encoding='UTF-8')
> My patch adds similar handling for sys.stdout.

Oh, sorry. Still I think it would be better to avoid duplication of 'sys.version_info[0] >= 3' and 'import io' to prevent misreads

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181004/328b1100/attachment.html>