[Webkit-unassigned] [Bug 190188] Add retry for test groups with failed build requests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190188

--- Comment #7 from dewei_zhu at apple.com ---
Comment on attachment 351487
  --> https://bugs.webkit.org/attachment.cgi?id=351487
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351487&action=review

>> Websites/perf.webkit.org/tools/js/retry-failed-build-requests.js:7
>> +        if (testGroup.isHidden()) {
> 
> This early bail out is useless because we filter the results in API anyway.
> 
> Also we need to have an API test for this.

Can we remove if condition that checks testGroup.mayNeedMoreRequests() as well as the API also did that?
More general question, should we make assumptions on the testGroups provided in the argument?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181003/633857db/attachment.html>