[Webkit-unassigned] [Bug 190190] Allow run-javascriptcore-tests to distribute tests between devices

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 12:07:03 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190190

--- Comment #4 from Dominik Inführ <dinfuehr at igalia.com> ---
Comment on attachment 351525
  --> https://bugs.webkit.org/attachment.cgi?id=351525
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351525&action=review

> Tools/Scripts/run-jsc-stress-tests:233
> +        $remoteHosts << RemoteHost.new("default-#{$remoteHosts.length.to_s}", uri.user, uri.host, uri.port)

`.to_s` shouldn't be necessary here.

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:338
> +    File.open($runnerDir + "Makefile.#{remoteIndex.to_s}", "w") {

`.to_s` shouldn't be necessary here.

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:365
> +        command = "make -j #{$numChildProcesses.to_s} -s -f Makefile.#{remoteIndex.to_s}"

`.to_s` shouldn't be necessary here.

> Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:410
> +    File.open($runnerDir + "Makefile.#{remoteIndex.to_s}", "w") {

`.to_s` shouldn't be necessary here.

> Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:437
> +        command = "make -j #{$numChildProcesses.to_s} -s -f Makefile.#{remoteIndex.to_s}"

ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181003/d7119d73/attachment.html>


More information about the webkit-unassigned mailing list