[Webkit-unassigned] [Bug 190255] [GTK][WPE] VDMX vertical font metrics support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 11:13:21 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190255

Build Bot <ews at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ews at webkit.org

--- Comment #2 from Build Bot <ews at webkit.org> ---
Attachment 351536 did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.h:31:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.h:36:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.h:37:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.h:38:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:31:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:93:  Declaration has space between type name and * in const uint8_t *const  [whitespace/declaration] [3]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:120:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:121:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/freetype/VDMXParser.cpp:153:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 12 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181003/e0b61754/attachment-0001.html>


More information about the webkit-unassigned mailing list