[Webkit-unassigned] [Bug 187039] Add support for testdriver WPT tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187039

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351375|review?                     |review-
              Flags|                            |

--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 351375
  --> https://bugs.webkit.org/attachment.cgi?id=351375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351375&action=review

> LayoutTests/imported/w3c/ChangeLog:6
> +

Extra white spaces.

> LayoutTests/imported/w3c/ChangeLog:7
> +        Add support for testdriver WPT tess

tests

> LayoutTests/imported/w3c/ChangeLog:15
> +

I think you should unskip testdriver tests from LayoutTests/infrastructure in order to have something to test.

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver.js:3
> +

So talking with Youenn, the proper way to implement this is actually to import the existing testdriver.js from upstream WPT (so that it implements window.test_driver) and implement testdriver-vendor.js so that it overrides window.test_driver_internal (or whatever else must be modified).

For example infrastructure/testdriver/click.html loads both files:
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

BTW, there should be some doc on upstream WPT explaining that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181002/b1226efd/attachment.html>