[Webkit-unassigned] [Bug 188834] AudioNode.connect does not return destination node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188834

--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
(In reply to Walker Henderson from comment #8)
> Comment on attachment 351198 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351198&action=review
> 
> >> Source/WebCore/Modules/webaudio/AudioNode.idl:37
> >> +    [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
> > 
> > I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up.
> 
> Gotcha, should I put together a new patch for that? If so, should the patch
> be attached to a new bug?

Why don't you file a new bug and reference this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181002/2fb223a8/attachment.html>