[Webkit-unassigned] [Bug 188598] [JSC] Remove gcc warnings on mips and armv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 13:22:03 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188598

--- Comment #31 from Mark Lam <mark.lam at apple.com> ---
@Guillaume, I want you to understand why bitwise_cast was suggested as an alternative to IGNORE_CAST_ALIGN_WARNINGS: using bitwise_cast means we want the code to just treat the pointer bits as the new type, and that the author already knows that the bits will work correctly as the new type.  This is why we don't need to disable the warnings.

However, you will find that bmalloc (which sits below WTF) will have no knowledge of bitwise_cast yet (which is defined in WTF).  bmalloc needs its own copy of bitwise_cast.  I suggest copying the bitwise_cast template to bamlloc's Algorithm.h and then using it in the code instead of the IGNORE_CAST_ALIGN_WARNINGS macro.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181001/6ca6ba7c/attachment.html>


More information about the webkit-unassigned mailing list