[Webkit-unassigned] [Bug 188598] [JSC] Remove gcc warnings on mips and armv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188598

--- Comment #25 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 350104
  --> https://bugs.webkit.org/attachment.cgi?id=350104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350104&action=review

Looks good but let's fix the ScriptExecutable::prepareForExecutionImpl() part as well.

> Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:141
> +        // of the required size, which should be properly aligned on platforms

nit: I would say "which should already be"

> Source/JavaScriptCore/bytecode/CodeBlock.h:1064
> +    JSObject* exception = prepareForExecutionImpl(vm, function, scope, kind, resultCodeBlock);
> +    if (exception) {
> +        IGNORE_CAST_ALIGN_WARNINGS_BEGIN
> +        return std::optional<Exception *>(reinterpret_cast<Exception*>(exception));
> +        IGNORE_CAST_ALIGN_WARNINGS_END
> +    } else
> +        return std::nullopt;

Let's just make ScriptExecutable::prepareForExecutionImpl() return a std::optional<Exception*> as well.  I don't see a good reason for doing this half way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181001/995c3c0e/attachment.html>