[Webkit-unassigned] [Bug 190121] [WTF] r236617 broke JSCOnly build on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 03:13:23 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190121

--- Comment #1 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
(In reply to Koby from comment #0)
> Hi,
> After updating my copy of WebKit, the Windows build of JSCOnly port fails
> with the following error:
> c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric.
> cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such
> file or directory [C
> :\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF.
> vcxproj]
> 
> Looking at the file, it seems that since r236617 MainThreadGeneric.cpp
> always includes pthread.h, which is a problem since it isn't available on
> Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms).
> 
> What do you think? should this be fixed in MainThreadGeneric or should the
> JSCOnly use the Windows implementation of MainThread?
> 
> Thanks,
> Koby

Use MainThreadWin instead in Window.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181001/47fb09ec/attachment.html>


More information about the webkit-unassigned mailing list