[Webkit-unassigned] [Bug 190121] New: [WTF] r236617 broke JSCOnly build on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190121

            Bug ID: 190121
           Summary: [WTF] r236617 broke JSCOnly build on Windows
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: koby.b at mce.systems

Hi,
After updating my copy of WebKit, the Windows build of JSCOnly port fails with the following error:
c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric.cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C
:\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF.vcxproj]

Looking at the file, it seems that since r236617 MainThreadGeneric.cpp always includes pthread.h, which is a problem since it isn't available on Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms).

What do you think? should this be fixed in MainThreadGeneric or should the JSCOnly use the Windows implementation of MainThread?

Thanks,
Koby

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181001/6eb4d719/attachment-0001.html>