[Webkit-unassigned] [Bug 192030] Layout test should generate performance metrics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192030

--- Comment #12 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 356101
  --> https://bugs.webkit.org/attachment.cgi?id=356101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356101&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:412
> +            initial_results.results_by_name.values())

This seems like it would be fine on 1 line.

Side note, the one part of PEP-8 we ignore is the line size limit

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:414
> +            self._results_directory, "layout_test_perf_metrics.json")

Why a new-line here?

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:125
> +    Will need to generate the total runtime of layout tests as a perfromance metric

This seems like a description of what needs to be done as opposed to what has been done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181130/8e00f385/attachment.html>