[Webkit-unassigned] [Bug 192077] New: [WebDriver] Fix clang warnings in Session.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 28 08:45:51 PST 2018
https://bugs.webkit.org/show_bug.cgi?id=192077
Bug ID: 192077
Summary: [WebDriver] Fix clang warnings in Session.cpp
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebDriver
Assignee: webkit-unassigned at lists.webkit.org
Reporter: tpopela at redhat.com
CC: bburg at apple.com
../../Source/WebDriver/Session.cpp:244:23: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
dismissAlert([this, errorResult = WTFMove(result), completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
^~~~~
../../Source/WebDriver/Session.cpp:257:22: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
acceptAlert([this, errorResult = WTFMove(result), completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
^~~~~
../../Source/WebDriver/Session.cpp:269:19: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
getAlertText([this, completionHandler = WTFMove(completionHandler)](CommandResult&& result) {
^~~~~
../../Source/WebDriver/Session.cpp:331:84: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("getBrowsingContext"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:451:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:480:80: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("getBrowsingContext"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:558:84: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("getBrowsingContexts"_s, JSON::Object::create(), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:689:80: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("getBrowsingContext"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:918:82: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("computeElementLayout"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
^~~~~
../../Source/WebDriver/Session.cpp:1115:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1166:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1207:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1239:47: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
computeElementLayout(elementID, { }, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](std::optional<Rect>&& rect, std::optional<Point>&&, bool, RefPtr<JSON::Object>&& error) {
^~~~~
../../Source/WebDriver/Session.cpp:1275:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1316:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1358:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1399:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1440:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1501:81: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("selectOptionElement"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1532:94: warning: lambda capture 'isObscured' is not used [-Wunused-lambda-capture]
getElementTagName(elementID, [this, elementID, inViewCenter = WTFMove(inViewCenter), isObscured, completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
~~^~~~~~~~~~
../../Source/WebDriver/Session.cpp:1572:88: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1824:12: warning: local variable 'resultValue' will be copied despite being returned by name [-Wreturn-std-move]
return resultValue;
^~~~~~~~~~~
../../Source/WebDriver/Session.cpp:1824:12: note: call 'std::move' explicitly to avoid copying
return resultValue;
^~~~~~~~~~~
std::move(resultValue)
../../Source/WebDriver/Session.cpp:1928:85: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("performMouseInteraction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:1962:89: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("performKeyboardInteractions"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2049:79: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("getAllCookies"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
^~~~~
../../Source/WebDriver/Session.cpp:2082:20: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
getAllCookies([this, name, completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
^~~~~
../../Source/WebDriver/Session.cpp:2119:81: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("addSingleCookie"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2144:84: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("deleteSingleCookie"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2168:82: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("deleteAllCookies"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2340:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("performInteractionSequence"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] (SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2362:87: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("cancelInteractionSequence"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2380:92: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("dismissCurrentJavaScriptDialog"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2398:91: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("acceptCurrentJavaScriptDialog"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2416:94: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("messageOfCurrentJavaScriptDialog"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2440:100: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("setUserInputForCurrentJavaScriptPrompt"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
^~~~~
../../Source/WebDriver/Session.cpp:2471:80: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_host->sendCommandToBackend("takeScreenshot"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
^~~~~
36 warnings generated.
[207/1963] Building CXX object Source/WebDriver/CMakeFiles/WebDriver.dir/WebDriverService.cpp.o
../../Source/WebDriver/WebDriverService.cpp:761:21: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
session->close([this, session, completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
^~~~~
1 warning generated.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181128/56b59b06/attachment-0001.html>
More information about the webkit-unassigned
mailing list