[Webkit-unassigned] [Bug 191934] Updating href on linearGradient and radialGradient doesn't update its rendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191934

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
A couple of issues here, by the look of it.

First, a radial gradient with r="0" doesn't seem to render a solid color, so even if the attribute changing worked, you'd see nothing.

Second, I think SVGGradientElement::svgAttributeChanged() needs to be like:

 void SVGGradientElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (isKnownAttribute(attrName)) {
+    if (isKnownAttribute(attrName) || SVGURIReference::isKnownAttribute(attrName)) {
         InstanceInvalidationGuard guard(*this);
         if (RenderObject* object = renderer())
             object->setNeedsLayout();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181128/da1a53aa/attachment.html>