[Webkit-unassigned] [Bug 192032] Make generic EventHandler methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192032

Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |don.olmstead at sony.com

--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 355778
  --> https://bugs.webkit.org/attachment.cgi?id=355778
Move EventHandler methods from EventHandlerGlib

View in context: https://bugs.webkit.org/attachment.cgi?id=355778&action=review

Overall LGTM.

What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code? Should that just be a !PLATFORM(GTK)in EventHandler.cpp since WPE doesn't actually implement. Then it would be EventHandlerGtk.cpp.

> Source/WebCore/page/EventHandler.cpp:4279
> +#if !PLATFORM(MAC) && !PLATFORM(IOS)

This could be simplified to !PLATFORM(COCOA)

> Source/WebCore/page/EventHandler.cpp:4338
> +#if !PLATFORM(MAC) && !PLATFORM(IOS) && !PLATFORM(WIN)

Same

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181128/6e42272a/attachment.html>