[Webkit-unassigned] [Bug 191999] [EME][ClearKey][GTK] Update ClearKey tests expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 08:05:54 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=191999

--- Comment #2 from Charlie Turner <cturner at igalia.com> ---
Comment on attachment 355726
  --> https://bugs.webkit.org/attachment.cgi?id=355726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355726&action=review

Thanks Yacine! Just a small issue with the DRT output in this patch, but the rest LGTM. We'll need to wait for a formal review before landing though :)

> LayoutTests/platform/gtk/TestExpectations:-1212
> -webkit.org/b/190738 imported/w3c/web-platform-tests/encrypted-media/resources/clearkey-retrieve-persistent-license.html [ Missing ]

Please keep these two [ Missing ] expectations, they are not tests, but rather helper files, and including them introduces the DRT output you have included in this patch.

> LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encrypted-media/resources/clearkey-retrieve-destroy-persistent-license-expected.txt:1
> +layer at (0,0) size 800x600

All these DRT outputs can be removed, (see above)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181127/879688f6/attachment.html>


More information about the webkit-unassigned mailing list