[Webkit-unassigned] [Bug 191998] [GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191998

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
> There's a
> if (DEFINED ENABLE_OPENGL)
>   WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_OPENGL)
> endif ()
> 
> but this part appears to still fail.

I think the problem is that the dependency is not added if ENABLE_OPENGL is not defined. The intent was for that to disable USE_GSTREAMER_GL if ENABLE_OPENGL is turned off, but the effect is to do nothing because the code will only be executed if ENABLE_OPENGL is on. The condition was probably added because the file is shared between GTK and WPE, and WPE does not have an ENABLE_OPENGL option.

Please test this speculative fix:

if (PORT STREQUAL "GTK")
    WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_OPENGL)
endif ()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181127/45b2f2d6/attachment.html>