[Webkit-unassigned] [Bug 191997] REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191997

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com,
                   |                            |zan at falconsigh.net
            Summary|[GTK] Undefined references  |REGRESSION(r231043): [GTK]
                   |to                          |Undefined references to
                   |WebCore::LayerRepresentatio |WebCore::LayerRepresentatio
                   |n::* with                   |n::* with
                   |-DENABLE_OPENGL=OFF builds  |-DENABLE_OPENGL=OFF builds

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
The fix for this is not obvious to me, but I guess the build guards are wrong in ScrollingStateNode.h:

#if ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS)

Expresses the intent for this file to work if USE(COORDINATED_GRAPHICS) is disabled, but it doesn't.

Another option would be to add explicit dependencies at the CMake level if async scrolling really is supposed to depend on coordinated graphics, but they would have to be duplicated in both OptionsGTK.cmake and OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option:

WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181127/4b4a13fd/attachment-0001.html>