[Webkit-unassigned] [Bug 191996] New: WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191996

            Bug ID: 191996
           Summary: WebKit.AddAndRemoveDataDetectors hits a debug
                    assertion after r238515
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wenson_hsieh at apple.com

>From logging in decode(Decoder& decoder, NSArray<Class> *allowedClasses), it looks like what's happening is that the allowedClasses contains:

    @[ NSArray.class, DDScannerResult.class ]

...however, the decoded object is a type of __NSArrayM, which is not exactly equal to NSArray.class (instead, it's one of the concrete implementations of NSArray).

Example crash trace (from https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/1014/steps/run-api-tests/logs/stdio)

    TestWebKitAPI.WebKit.AddAndRemoveDataDetectors
        ASSERTION FAILED: [allowedClasses containsObject:[object class]]
        /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h(57) : std::optional<RetainPtr<T> > IPC::decode(IPC::Decoder &, NSArray<Class> *) [T = NSArray]
        1   0x106fbd359 WTFCrash
        2   0x10ab7975b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x10af506d4 std::optional<WTF::RetainPtr<NSArray> > IPC::decode<NSArray>(IPC::Decoder&, NSArray<objc_class*>*)
        4   0x10af5038b WebKit::DataDetectionResult::decode(IPC::Decoder&)
        5   0x10bb8556c std::optional<WebKit::DataDetectionResult> IPC::ArgumentCoder<WebKit::DataDetectionResult>::decode<WebKit::DataDetectionResult, (void*)0>(IPC::Decoder&)
        6   0x10bb65f54 IPC::Decoder& IPC::Decoder::operator>><WebKit::DataDetectionResult, (void*)0>(std::optional<WebKit::DataDetectionResult>&)
        7   0x10bb65e59 Messages::WebPage::DetectDataInAllFrames::callReply(IPC::Decoder&, WTF::CompletionHandler<void (WebKit::DataDetectionResult&&)>&&)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181127/1bfa2db3/attachment.html>