[Webkit-unassigned] [Bug 191953] Remote tile layers shouldn't be UIViews

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191953

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355599|review?                     |review+
              Flags|                            |

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355599
  --> https://bugs.webkit.org/attachment.cgi?id=355599
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355599&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:75
> +    if (uiView()) {

Maybe grab it and store it in a local? ('if (auto view = uiView()) [view removeFromSuperview];') It likely doesn't matter, but it seems nicer.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:95
> +NSString* RemoteLayerTreeNode::appendLayerDescription(NSString* description, CALayer* layer)

Star's on the wrong side. (seems like this file is full of that)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181126/d7d5ab7c/attachment.html>