[Webkit-unassigned] [Bug 191913] Address post-review feedback after r238438
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 22 12:36:41 PST 2018
https://bugs.webkit.org/show_bug.cgi?id=191913
--- Comment #1 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Wenson Hsieh from comment #0)
> • Make Editor::setSelectedRange take enum classes instead of bools.
I meant to write `FrameSelection::setSelectedRange`.
> • Make Editor::replaceSelectionWithText take enum classes instead of bools.
> • Don't pass in Vector&&s for a few functions that don't take ownership of
> the Vector.
> • ...and a couple of other small items.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181122/184fcc58/attachment.html>
More information about the webkit-unassigned
mailing list