[Webkit-unassigned] [Bug 191548] Enable JIT on ARM/Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191548

Yusuke Suzuki <yusukesuzuki at slowstart.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355356|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 355356
  --> https://bugs.webkit.org/attachment.cgi?id=355356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355356&action=review

r=me

> Source/JavaScriptCore/bytecode/InstructionStream.cpp:49
> +    const Instruction* begin = at(0).ptr();
> +    const Instruction* end = reinterpret_cast<const Instruction*>(reinterpret_cast<const uint8_t*>(begin) + size());
> +
> +    return instruction >= begin && instruction < end;

Actually, you do not need to use `Instruction*` here. You can define this function simply by,

const uint8_t* pointer = bitwise_cast<const uint8_t*>(instruction);
return pointer >= m_instructions.data() && pointer < (m_instructions.data() + m_instructions.size());

> Source/JavaScriptCore/jit/GPRInfo.h:531
> +#define NUMBER_OF_CALLEE_SAVES_REGISTERS 1u

This is only correct for ARM_THUMB2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181121/aa8f7d4b/attachment.html>