[Webkit-unassigned] [Bug 191854] Remove the need for LocalizedStringsWPE.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191854

--- Comment #8 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Christopher Reid from comment #7)
> Comment on attachment 355326 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355326&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        of String::fromUTF8. Move that to LocalizedString.cpp as the default implement
> 
> Just noticed this typo, will change implement to implementation before
> landing
> 
> >> Source/WebCore/en.lproj/Localizable.strings:602
> >> +"Search the Web" = "Search the Web";
> > 
> > I have a feeling we might want to keep the original and add the new one. I'm not sure how this will affect XCode builds.
> 
> That string seems to only be used in windows CF ports. COCOA is using the
> "Search with %@" string. I'm not certain about the NSPerformService(@"Search
> With Google", pasteboard); call in WebKitLegacy's WebView.mm but it looks
> like it's only used for invoking a context menu action and not for the
> context menu text so it doesn't seem to be doing localization. I'm not
> familiar enough with NSPerformService to confirm whether that's true or not.
> If it is the case, I don't see much value in keeping the original string
> around.

Ok then I guess this is good to go after you fix your typo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181120/ada2bf7c/attachment.html>