[Webkit-unassigned] [Bug 178900] [WPE] Add gtk-doc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178900

--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 355328
  --> https://bugs.webkit.org/attachment.cgi?id=355328
ready for review

View in context: https://bugs.webkit.org/attachment.cgi?id=355328&action=review

Looks sane to me.

> Source/WebKit/PlatformWPE.cmake:152
> +# FIXME: Separate web-extension and DOM headers in two different lists for building separate documentations.

Actually I don't think it's required for WPE, since we have so few DOM headers. Probably easier to keep them together, unlike GTK. So you can remove this FIXME.

(GTK has a huge legacy DOM API that is not exposed by WPE.)

> Source/WebKit/PlatformWPE.cmake:339
> +# FIXME: WebExtension APIs are not included yet. The list of headers for WebExtension also has DOM headers.

We should create a separate documentation bundle for WebExtension/DOM.

> Source/WebKit/UIProcess/API/wpe/WebKitWebContext.h:252
> +WEBKIT_API void
> +webkit_web_context_set_sandbox_enabled              (WebKitWebContext               *context,
> +                                                     gboolean                       enabled);

Why was this moved?

The spacing is off by one (enabled should be aligned with the c of context.)

> Source/WebKit/UIProcess/API/wpe/docs/wpe-0.1-sections.txt:1467
> +<SECTION>
> +<FILE>WebKitDOMObject</FILE>
> +<TITLE>WebKitDOMObject</TITLE>
> +WebKitDOMObject

It should be simple to split the web process APIs into separate documentation, right?

> Source/WebKit/UIProcess/API/wpe/docs/wpe-docs.sgml:70
> +  <!-- FIXME: Move WebKitDOM to its own documentation if the number of DOM APIs increases -->

Let's just have one manual for UI process, and a second manual for web extensions (including DOM).

> Source/WebKit/WebProcess/InjectedBundle/API/wpe/WebKitWebPage.h:79
> +WEBKIT_API WebKitDOMDocument *
> +webkit_web_page_get_dom_document (WebKitWebPage *web_page);
> +

Why is this moved?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181120/73b2cca8/attachment.html>