[Webkit-unassigned] [Bug 191830] Disable tests on systems without WebAssembly enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 11:23:48 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=191830

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guijemont at igalia.com

--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Dominik, if the issue has already been fixed, you should:
1. include the URL of the revision that fixed the issue.  In this case, that would be:
   https://trac.webkit.org/changeset/238373/webkit
2. Clear the flags on your patch so that they don't stay at r? and cq?.

For tests that relies on wasm like this, the better fix is to put them in the JSTests/wasm/stress/ or JSTests/wasm/regress/ directories instead.  You don't need an isWebAssemblyEnabled flag.

Guillaume's fix is certainly still valid to indicate that the test is memory hungry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181119/d95c402c/attachment.html>


More information about the webkit-unassigned mailing list