[Webkit-unassigned] [Bug 191689] Crash in [WKWebView _addUpdateVisibleContentRectPreCommitHandler]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191689

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=187376
         Resolution|---                         |CONFIGURATION CHANGED

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
I wrote myself a note from WWDC 2018 about this method because another external developer talked to me about this crash as well.  The only thing I wrote down is that we should use a weak reference instead of a strong reference in the block:

<https://trac.webkit.org/browser/trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm#L2775>

The only reason to use a weak reference here would be to protect against some other code over-releasing the WKWebView object, though, because the strong reference should work just fine.

Interestingly, Simon Fraser made this change during iOS 12 development (during the public seeds):

    Bug 187376: Address two possible causes of missing tiles in iOS Safari, and add logging to gather more data about other possible causes
    <https://bugs.webkit.org/show_bug.cgi?id=187376>
    <https://trac.webkit.org/r233561>

According to our internal crash data, this crash was last seen in iOS 12 Dev Seed 3/Public Seed 2 (build 16A5318d).  Are you seeing this crash after that build?

It seems like this is fixed in iOS 12.0 and later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181118/4bb78367/attachment.html>